Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workers/jobs/dump_db: Remove unnecessary target_name field #8719

Merged
merged 1 commit into from
May 24, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented May 24, 2024

We haven't used this in years and it makes it a bit more complicated to support other file types in the future.

Related:

We haven't used this in years and it makes it a bit more complicated to support other file types in the future.
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 88.48%. Comparing base (26c9e28) to head (e1affbb).
Report is 5 commits behind head on main.

Files Patch % Lines
src/worker/jobs/dump_db.rs 0.00% 5 Missing ⚠️
src/admin/enqueue_job.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8719      +/-   ##
==========================================
+ Coverage   88.45%   88.48%   +0.02%     
==========================================
  Files         276      276              
  Lines       27449    27446       -3     
==========================================
+ Hits        24281    24285       +4     
+ Misses       3168     3161       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit ae793df into rust-lang:main May 24, 2024
8 checks passed
@Turbo87 Turbo87 deleted the target-name branch May 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant