workers/jobs/dump_db: Remove unnecessary target_name field (#8719)

We haven't used this in years and it makes it a bit more complicated to support other file types in the future.

src/admin/enqueue_job.rs

@@ -25,8 +25,6 @@ pub enum Command {
     DumpDb {
         #[arg(env = "READ_ONLY_REPLICA_URL")]
         database_url: SecretString,
-        #[arg(default_value = "db-dump.tar.gz")]
-        target_name: String,
     },
     DailyDbMaintenance,
     SquashIndex,
@@ -76,11 +74,8 @@ pub fn run(command: Command) -> Result<()> {
         Command::CleanProcessedLogFiles => {
             jobs::CleanProcessedLogFiles.enqueue(conn)?;
         }
-        Command::DumpDb {
-            database_url,
-            target_name,
-        } => {
-            jobs::DumpDb::new(database_url.expose_secret(), target_name).enqueue(conn)?;
+        Command::DumpDb { database_url } => {
+            jobs::DumpDb::new(database_url.expose_secret()).enqueue(conn)?;
         }
         Command::SyncAdmins { force } => {
             if !force {

src/worker/jobs/dump_db.rs

@@ -11,14 +11,12 @@ use std::sync::Arc;
 #[derive(Clone, Serialize, Deserialize)]
 pub struct DumpDb {
     database_url: String,
-    target_name: String,
 }
 
 impl DumpDb {
-    pub fn new(database_url: impl Into<String>, target_name: impl Into<String>) -> Self {
+    pub fn new(database_url: impl Into<String>) -> Self {
         Self {
             database_url: database_url.into(),
-            target_name: target_name.into(),
         }
     }
 }
@@ -31,6 +29,7 @@ impl BackgroundJob for DumpDb {
     /// Create CSV dumps of the public information in the database, wrap them in a
     /// tarball and upload to S3.
     async fn run(&self, env: Self::Context) -> anyhow::Result<()> {
+        let target_name = "db-dump.tar.gz";
         let database_url = self.database_url.clone();
 
         let tarball = spawn_blocking(move || {
@@ -46,19 +45,19 @@ impl BackgroundJob for DumpDb {
 
         info!("Uploading tarball");
         Storage::from_environment()
-            .upload_db_dump(&self.target_name, &tarball.tarball_path)
+            .upload_db_dump(target_name, &tarball.tarball_path)
             .await?;
         info!("Database dump tarball uploaded");
 
         info!("Invalidating CDN caches");
         if let Some(cloudfront) = env.cloudfront() {
-            if let Err(error) = cloudfront.invalidate(&self.target_name).await {
+            if let Err(error) = cloudfront.invalidate(target_name).await {
                 warn!("failed to invalidate CloudFront cache: {}", error);
             }
         }
 
         if let Some(fastly) = env.fastly() {
-            if let Err(error) = fastly.invalidate(&self.target_name).await {
+            if let Err(error) = fastly.invalidate(target_name).await {
                 warn!("failed to invalidate Fastly cache: {}", error);
             }
         }