Cleanup Windows trace modules #697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows 64-bit doesn't use dbghelp for tracing, so the name was confusing.
|
Thanks. Is there a specific reason to keep dbghelp32 as dbghelp32 instead of win32? |
|
Not really, other than it didn't occur to me. I can totally do that though. |
|
Done! |
|
The windows-gnu error is caused by rust-lang/rust#136096 which in turn is caused by old mingw emitting a bunch of warnings in stderr. These aren't new but erroring on them is. Considering the lint is going to be downgraded to allow until it is less noisy, maybe we should just wait a day or two for that to be merged. |
|
Yeah I'm fine with just waiting a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 64-bit doesn't use dbghelp for tracing, so the name
dbghelp64.rswas inaccurate and confusing. Rename it towin64.rs.Also I moved a stray comment from
dbghelp32.rstowin64.rsand removed#![allow(bad_style)]from both modules.