Make from_char_unchecked public
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `gf32::Error` type is too general. Split the error into two separate error types so that `from_char` and `try_from` each return an error type in which all variants are used.
The `from_char_unchecked` function is useful outside for users of the crate, make it public and document the panic case. Add rustdocs to `from_char` and `from_char_unchecked`, and make `from_char_unchecked` public.
tcharding
force-pushed
the
01-08-from_char_unchecked
branch
from
cc2271a to
ca2f840
Compare
apoelstra
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_char.from_charand makesfrom_char_uncheckedpublic.Fix: #161