Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stats-lookup #7667

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create stats-lookup #7667

wants to merge 3 commits into from

Conversation

MKbrun
Copy link

@MKbrun MKbrun commented Mar 18, 2025

Plugin which allows the user to look up the stats on a monsters gathered from osrswiki

@runelite-github-app
Copy link

runelite-github-app bot commented Mar 18, 2025

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 18, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 19, 2025
@iProdigy
Copy link
Member

Please use the version of okhttp that is already bundled by the runelite client

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 19, 2025
@Nightfirecat
Copy link
Member

This really should not query the wiki every time a lookup is performed; instead, it would be much better to scrape the wiki for this data periodically and have the plugin fetch that scraped data.
(separately, I don't really understand the point of this plugin when the wiki lookup button exists)

@coopermor
Copy link

The wiki dps calc already scrapes the wiki to create a monsters.json which is kept up to date. If you did want the plugin to exist you can probably just parse the json data that is already being scraped. https://raw.githubusercontent.com/weirdgloop/osrs-dps-calc/refs/heads/main/cdn/json/monsters.json

@MKbrun
Copy link
Author

MKbrun commented Mar 19, 2025

The wiki dps calc already scrapes the wiki to create a monsters.json which is kept up to date. If you did want the plugin to exist you can probably just parse the json data that is already being scraped. https://raw.githubusercontent.com/weirdgloop/osrs-dps-calc/refs/heads/main/cdn/json/monsters.json

Thanks for this. Didn't know, but will try to use that instead

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 19, 2025
@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants