test: smoke test with cjs/esm dual package #1644
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
@llamaindex/autotool
@llamaindex/cloud
@llamaindex/community
@llamaindex/core
@llamaindex/env
@llamaindex/experimental
llamaindex
@llamaindex/node-parser
@llamaindex/readers
@llamaindex/wasm-tools
@llamaindex/workflow
@llamaindex/anthropic
@llamaindex/clip
@llamaindex/cohere
@llamaindex/deepinfra
@llamaindex/google
@llamaindex/groq
@llamaindex/huggingface
@llamaindex/mistral
@llamaindex/mixedbread
@llamaindex/ollama
@llamaindex/openai
@llamaindex/portkey-ai
@llamaindex/replicate
@llamaindex/vercel
@llamaindex/vllm
commit: |
| ); | ||
| await writeFile(filePath, esmCode, "utf-8"); | ||
|
|
||
| execSync(`${process.argv[0]} ${filePath}`, { |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
| ); | ||
| await writeFile(filePath, esmCode, "utf-8"); | ||
|
|
||
| execSync(`${process.argv[0]} ${filePath} -C ${condition}`, { |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 11 days ago
To fix the problem, we should avoid constructing the shell command as a single string and instead use execFileSync to pass the command and its arguments separately. This approach ensures that the shell does not misinterpret any special characters in the arguments.
- Replace the
execSynccalls withexecFileSyncto separate the command and its arguments. - Update the imports to include
execFileSyncfromnode:child_process.
| @@ -1,2 +1,2 @@ | ||
| import { execSync } from "node:child_process"; | ||
| import { execFileSync } from "node:child_process"; | ||
| import { mkdir, rm, writeFile } from "node:fs/promises"; | ||
| @@ -50,3 +50,3 @@ | ||
|
|
||
| execSync(`${process.argv[0]} ${filePath}`, { | ||
| execFileSync(process.argv[0], [filePath], { | ||
| cwd: process.cwd(), | ||
| @@ -64,3 +64,3 @@ | ||
|
|
||
| execSync(`${process.argv[0]} ${filePath}`, { | ||
| execFileSync(process.argv[0], [filePath], { | ||
| cwd: process.cwd(), | ||
| @@ -80,3 +80,3 @@ | ||
|
|
||
| execSync(`${process.argv[0]} ${filePath} -C ${condition}`, { | ||
| execFileSync(process.argv[0], [filePath, '-C', condition], { | ||
| cwd: process.cwd(), |
No description provided.