Draft Case Contact Filter Fix #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoork
requested review from
compwron,
FireLemons and
littleforest
as code owners
github-actions
bot
added
ruby
schoork
commented
Jan 23, 2024
| @@ -49,7 +49,7 @@ | |||
| </div> | |||
| <div class="field-card mt-4"> | |||
| <h5 class="mb-3"><%= form.label :occurred_at, "Occurred On" %>:</h5> | |||
| <% occurred_at = learning_hour.occurred_at || Time.zone.now %> | |||
| <% occurred_at = learning_hour.occurred_at || Date.today %> | |||
There was a problem hiding this comment.
Unrelated, but fixes some flakiness if the test is run late enough in the date that Time.zone.now ends up being tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Did not create an issue
What changed, and why?
Fixed Drafts not showing when only a single casa case was filtered.
How will this affect user permissions?
None
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9