Remove translation calls to config/locales directory #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ruby
FireLemons
reviewed
Jan 10, 2024
spec/requests/volunteers_spec.rb
Outdated
| @@ -374,7 +374,7 @@ | |||
|
|
|||
| expect(volunteer.invitation_created_at.present?).to eq(true) | |||
| expect(Devise.mailer.deliveries.count).to eq(1) | |||
| expect(Devise.mailer.deliveries.first.subject).to eq(I18n.t("devise.mailer.invitation_instructions.subject")) | |||
| expect(Devise.mailer.deliveries.first.subject).to eq("CASA Console invitation instructions") | |||
There was a problem hiding this comment.
Maybe revert this and spec/requests/supervisors_spec.rb, spec/requests/casa_admins_spec.rb because devise calls the translation in its default view file which is located in its library files so it's inaccessible.
fchagasjr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5470
What changed, and why?
Removed translation strings from locales folder.
Removed translation calls from app and test cases.
Updated localization calls to use I18n style.