Flaky test issue 5424 #5439
Merged
Flaky test issue 5424 #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroulston
requested review from
compwron,
FireLemons and
littleforest
as code owners
github-actions
bot
added
dependencies
FireLemons
requested changes
Dec 13, 2023
app/models/case_contact_report.rb
Outdated
| @@ -25,6 +25,7 @@ def filtered_case_contacts(args) | |||
| .contact_type(args[:contact_type_ids]) | |||
| .contact_type_groups(args[:contact_type_group_ids]) | |||
| .with_casa_case(args[:casa_case_ids]) | |||
| .order(:id) | |||
There was a problem hiding this comment.
Could you change the test instead of the app code?
There was a problem hiding this comment.
Sure no problem. Can I ask why it is preferable to go with Active Record's flaky ordering instead of explicit ordering? Happy to make the change, just pure curiosity.
There was a problem hiding this comment.
Generally you don't wanna change the app code to make a test run. You want to just change the test.
There was a problem hiding this comment.
Ah got it, thank you :)
hroulston
force-pushed
the
flaky_test_issue_5424
branch
from
e89aaba to
29d8182
Compare
…on before equality comparison
hroulston
force-pushed
the
flaky_test_issue_5424
branch
from
29d8182 to
cffebc2
Compare
hroulston
commented
Dec 14, 2023
schoork
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
I reverted the Gemfile.lock commit, since it didn't have to do with the test.
I like this match_array matcher. I had to do some reading on that. Nice work @hroulston!
schoork
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5424
What changed, and why?
In case_contact_report.rb file I ordered the Case Contacts by id under filtered_case_contacts method. Test passes since the order will match what is expected.
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Test already in place, didn't need to change anything.
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9