AssignMultipleVolunteersAtOnce //

response to test issues and code climate
rubyforgood · Jan 13, 2024 · f15d1ec · f15d1ec
1 parent 409aedc
commit f15d1ec
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/app/javascript/controllers/select_all_controller.js b/app/javascript/controllers/select_all_controller.js
@@ -43,14 +43,7 @@ export default class extends Controller {
     if (this.hasButtonTarget) {
       const numChecked = this.getNumberChecked()
       if (numChecked > 0) {
-        if (this.hasButtonLabelTarget) {
-          let label = this.buttonLabelValue
-          if (numChecked > 1) {
-            label += 's'
-          }
-          label += ' (' + numChecked + ')'
-          this.buttonLabelTarget.innerHTML = label
-        }
+        this.setButtonLabel(numChecked)
 
         this.buttonTarget.classList.remove(this.hiddenClass)
       } else {
@@ -59,6 +52,19 @@ export default class extends Controller {
     }
   }
 
+  setButtonLabel (numChecked) {
+    if (this.hasButtonLabelTarget) {
+      let label = this.buttonLabelValue
+
+      if (numChecked > 1) {
+        label += 's'
+      }
+      label += ' (' + numChecked + ')'
+
+      this.buttonLabelTarget.innerHTML = label
+    }
+  }
+
   getNumberChecked () {
     return this.checkboxTargets.filter((checkbox) => checkbox.checked).length
   }

diff --git a/spec/system/volunteers/index_spec.rb b/spec/system/volunteers/index_spec.rb
@@ -294,6 +294,7 @@
       before do
         sign_in admin
         visit volunteers_path
+        find("#supervisor_volunteer_volunteer_ids_#{volunteer.id}")
         find("#supervisor_volunteer_volunteer_ids_#{volunteer.id}").click
         find("[data-select-all-target='button']").click
       end