♻️ Use SASL::ClientAdapter #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
sasl/use-client-adapter
branch
from
2a55ec3 to
74fbf93
Compare
5 tasks
nevans
force-pushed
the
sasl/use-client-adapter
branch
3 times, most recently
from
bc2cc17 to
3ba0ccd
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
3 times, most recently
from
a523d11 to
74fb75f
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
from
74fb75f to
d30595d
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
from
d30595d to
1138862
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
from
1138862 to
7a70fd2
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
from
7a70fd2 to
e2e63ce
Compare
37 tasks
nevans
force-pushed
the
sasl/use-client-adapter
branch
2 times, most recently
from
d3d2335 to
c063ac0
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
6 times, most recently
from
5c633a4 to
2ff4010
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
3 times, most recently
from
2e2c88e to
56b028d
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
from
56b028d to
05824d8
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
from
05824d8 to
4d5dde5
Compare
nevans
force-pushed
the
sasl/use-client-adapter
branch
2 times, most recently
from
d1f6f2c to
dd0b91e
Compare
|
I'd been delaying this because I wanted to handle cancelation properly. But that isn't necessary: cancelation is no worse in the new implementation than it's ever been. So I split that work off into #324. |
nevans
force-pushed
the
sasl/use-client-adapter
branch
from
dd0b91e to
a5a5ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the experimental adapter created by #183.