Asynchronous pruning for RubyThreadPoolExecutor #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
better-ruby-thread-pool-executor-pruning
branch
15 times, most recently
from
b6e5656 to
f90d46d
Compare
joshuay03
commented
Feb 9, 2025
| @@ -114,9 +120,9 @@ def worker_task_completed | |||
| synchronize { @completed_task_count += 1 } | |||
| end | |||
|
|
|||
| # @!macro thread_pool_executor_method_prune_pool | |||
| def prune_pool | |||
There was a problem hiding this comment.
This public API no longer makes sense now that the pruning is automatic. It seems it was only added because of the Ruby thread pool's synchronous pruning, which the Java version didn't suffer from, hence why it's a no-op there.
joshuay03
force-pushed
the
better-ruby-thread-pool-executor-pruning
branch
14 times, most recently
from
c5eca7d to
89b67f4
Compare
joshuay03
force-pushed
the
better-ruby-thread-pool-executor-pruning
branch
10 times, most recently
from
57ae7ae to
9164d29
Compare
joshuay03
force-pushed
the
better-ruby-thread-pool-executor-pruning
branch
2 times, most recently
from
10f5833 to
76cd713
Compare
joshuay03
changed the title
joshuay03
force-pushed
the
better-ruby-thread-pool-executor-pruning
branch
12 times, most recently
from
e50c491 to
547428b
Compare
joshuay03
force-pushed
the
better-ruby-thread-pool-executor-pruning
branch
from
547428b to
a675844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1066
Closes #1075
Alternative to #1079
Implementation is based on the discussion in the linked issues.