Skip to content

Commit

Permalink
Adapt RakeCompilerDock to work with podman
Browse files Browse the repository at this point in the history
  • Loading branch information
eregon committed Jan 23, 2023
1 parent 4f38b78 commit 479a557
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ namespace :repackage do

# build all gem files
%w[x86-mingw32 x64-mingw32].each do |plat|
RakeCompilerDock.sh "bundle install --local && bundle exec rake native:#{plat} gem --trace", platform: plat
RakeCompilerDock.sh(
"bundle install --local && bundle exec rake native:#{plat} gem --trace",
platform: plat,
options: ['--privileged'], # otherwise the directory in the image is empty
runas: false)
end
end
end
Expand Down

2 comments on commit 479a557

@nirvdrum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke things in the other direction. When I build with Docker I get a mostly empty gem. When I revert this commit I get a properly constructed gem.

@eregon
Copy link
Collaborator Author

@eregon eregon commented on 479a557 Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed with 8f07f57

Please sign in to comment.