Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v3.5.0 #2043

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Release v3.5.0 #2043

merged 2 commits into from
Feb 16, 2025

Conversation

bquorning
Copy link
Collaborator

@bquorning bquorning commented Feb 16, 2025 •
edited
Loading

Changes in this release:

  • Don't let RSpec/PredicateMatcher replace respond_to? with two arguments with the RSpec respond_to matcher. (@bquorning)
  • Fix RSpec/PredicateMatcher support for eql and equal matchers. (@bquorning)
  • Pluginfy RuboCop RSpec. (@koic)

Full diff: v3.4.0...release

Also, we now have 100% code and branch coverage – thank you to @corsonknowles for helping and pushing for this change 🎉

@bquorning bquorning requested a review from a team as a code owner February 16, 2025 11:08
@bquorning bquorning requested a review from koic February 16, 2025 11:08
koic
koic approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing the release. I have tested the plugin-supported RuboCop RSpec in several repositories and have not found any issues.

@bquorning bquorning marked this pull request as draft February 16, 2025 11:20
@bquorning
Copy link
Collaborator Author

bquorning commented Feb 16, 2025 •
edited
Loading

I am going to push a few changes to include in this release (e.g. this), so moving it to draft for now.

@bquorning bquorning marked this pull request as ready for review February 16, 2025 11:55
@bquorning bquorning merged commit 4b14015 into master Feb 16, 2025
27 checks passed
@bquorning bquorning deleted the release branch February 16, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic approved these changes

@ydah ydah ydah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bquorning @koic @ydah