Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getter methods instead of instance variables #1795

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Use getter methods instead of instance variables #1795

merged 1 commit into from
Feb 1, 2024

Conversation

bquorning
Copy link
Collaborator

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning requested a review from a team as a code owner January 31, 2024 22:13
@bquorning
Copy link
Collaborator Author

cc @G-Rath

ydah
ydah approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pirj pirj merged commit f062f92 into master Feb 1, 2024
24 checks passed
@pirj pirj deleted the use-getters-and-setters branch February 1, 2024 07:05
@pirj
Copy link
Member

pirj commented Feb 1, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydah ydah ydah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bquorning @pirj @ydah