Implement #negated? in superclass #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All current matchers follow the pattern of negative assertions matching `assert_not_*` and `refute_*`. If we add a matcher where the negative assertions do not match this pattern, the method can still be overwritten in that subclass.
|
cc @G-Rath |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All current matchers follow the pattern of negative assertions matching
assert_not_*andrefute_*. If we add a matcher where the negative assertions do not match this pattern, the method can still be overwritten in that subclass.Before submitting the PR make sure the following are checked:
master(if not - rebase it).Added tests.Updated documentation.Added an entry to theCHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).