feat: support *_includes assertions in RSpec/Rails/MinitestAssertions
#1779
Conversation
| (send nil? {:assert_empty :assert_not_empty :refute_empty} $_ $_?) | ||
| PATTERN | ||
|
|
||
| def on_send(node) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize |
There was a problem hiding this comment.
I've just disabled AbcSize for now because I don't want to go too far from #1778 until it's landed, but I think a good next step for improving this could be to move the node matchers / block into the assertion classes too, so it becomes something like:
EqualAssertion.check(node)
IncludesAssertion.check(node)
NilAssertion.check(node)
EmptyAssertion.check(node)
# ...
(which you could probably take further by having an ASSERTION_CHECKERS array, and then the rest of this rule just iterates over that in a few places to pull through node matchers, restrict sends, check, etc)
| @@ -30,66 +30,146 @@ class MinitestAssertions < Base | |||
| RESTRICT_ON_SEND = %i[ | |||
| assert_equal | |||
| assert_not_equal | |||
| refute_equal | |||
| assert_includes | |||
| assert_not_includes | |||
There was a problem hiding this comment.
It's defined by Rails: https://github.com/rails/rails/blob/main/activesupport/lib/active_support/test_case.rb#L206
| @@ -28,11 +30,14 @@ class MinitestAssertions < Base | |||
| RESTRICT_ON_SEND = %i[ | |||
| assert_equal | |||
| assert_not_equal | |||
| assert_includes | |||
| assert_not_includes | |||
| assert_nil | |||
| assert_not_nil | |||
There was a problem hiding this comment.
There’s an “a-ha” moment, since all those assert_no_* are from test-unit, not minitest.
But I’d say we don’t care much if there’s a corresponding native RSpec expectation/matcher we can suggest using instead.
test-unit assertions https://www.rubydoc.info/gems/test-unit/2.3.2/Test/Unit/Assertions
Minitest assertions https://ruby-doc.org/stdlib-3.0.0/libdoc/minitest/rdoc/Minitest/Assertions.html
There was a problem hiding this comment.
Yea though also they're defined by Rails which is actually why I was including them: https://github.com/rails/rails/blob/main/activesupport/lib/active_support/test_case.rb#L206
G-Rath
force-pushed
the
support-assert-includes
branch
3 times, most recently
from
a58d40c to
9a97e40
Compare
G-Rath
force-pushed
the
support-assert-includes
branch
from
9a97e40 to
847e6a3
Compare
Branched off #1778This adds support for the
includesassertionsrelated to rubocop/rubocop-rspec_rails#7
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
Added the new cop toconfig/default.yml.The cop is configured asEnabled: pendinginconfig/default.yml.The cop is configured asEnabled: truein.rubocop.yml.The cop documents examples of good and bad code.The tests assert both that bad code is reported and that good code is not reported.SetVersionAdded: "<<next>>"indefault/config.yml.If you have modified an existing cop's configuration options:
SetVersionChanged: "<<next>>"inconfig/default.yml.