Add new RSpec/RemoveConst cop

.rubocop.yml

@@ -179,6 +179,8 @@ RSpec/RedundantAround:
   Enabled: true
 RSpec/RedundantPredicateMatcher:
   Enabled: true
+RSpec/RemoveConst:
+  Enabled: true
 RSpec/SkipBlockInsideExample:
   Enabled: true
 RSpec/SortMetadata:

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Add new `RSpec/RedundantPredicateMatcher` cop. ([@ydah])
 - Add support for correcting "it will" (future tense) for `RSpec/ExampleWording`. ([@jdufresne])
+- Add new `RSpec/RemoveConst` cop. ([@swelther])
 
 ## 2.25.0 (2023-10-27)
 
@@ -913,6 +914,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@smcgivern]: https://github.com/smcgivern
 [@splattael]: https://github.com/splattael
 [@stephannv]: https://github.com/stephannv
+[@swelther]: https://github.com/swelther
 [@t3h2mas]: https://github.com/t3h2mas
 [@tdeo]: https://github.com/tdeo
 [@tejasbubane]: https://github.com/tejasbubane

config/default.yml

@@ -777,6 +777,12 @@ RSpec/RedundantPredicateMatcher:
   VersionAdded: "<<next>>"
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantPredicateMatcher
 
+RSpec/RemoveConst:
+  Description: Checks that `remove_const` is not used in specs.
+  Enabled: pending
+  VersionAdded: "<<next>>"
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RemoveConst
+
 RSpec/RepeatedDescription:
   Description: Check for repeated description strings in example groups.
   Enabled: true

docs/modules/ROOT/pages/cops.adoc

@@ -81,6 +81,7 @@
 * xref:cops_rspec.adoc#rspecreceivenever[RSpec/ReceiveNever]
 * xref:cops_rspec.adoc#rspecredundantaround[RSpec/RedundantAround]
 * xref:cops_rspec.adoc#rspecredundantpredicatematcher[RSpec/RedundantPredicateMatcher]
+* xref:cops_rspec.adoc#rspecremoveconst[RSpec/RemoveConst]
 * xref:cops_rspec.adoc#rspecrepeateddescription[RSpec/RepeatedDescription]
 * xref:cops_rspec.adoc#rspecrepeatedexample[RSpec/RepeatedExample]
 * xref:cops_rspec.adoc#rspecrepeatedexamplegroupbody[RSpec/RepeatedExampleGroupBody]

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -4525,6 +4525,38 @@ expect(foo).not_to include(bar)
 
 * https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantPredicateMatcher
 
+== RSpec/RemoveConst
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| No
+| <<next>>
+| -
+|===
+
+Checks that `remove_const` is not used in specs.
+
+=== Examples
+
+[source,ruby]
+----
+# bad
+it 'does something' do
+  Object.send(:remove_const, :SomeConstant)
+end
+
+before do
+  SomeClass.send(:remove_const, :SomeConstant)
+end
+----
+
+=== References
+
+* https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RemoveConst
+
 == RSpec/RepeatedDescription
 
 |===

lib/rubocop/cop/rspec/remove_const.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks that `remove_const` is not used in specs.
+      #
+      # @example
+      #   # bad
+      #   it 'does something' do
+      #     Object.send(:remove_const, :SomeConstant)
+      #   end
+      #
+      #   before do
+      #     SomeClass.send(:remove_const, :SomeConstant)
+      #   end
+      #
+      class RemoveConst < Base
+        include RuboCop::RSpec::Language
+        extend RuboCop::RSpec::Language::NodePattern
+
+        MSG = 'Do not use remove_const in specs. ' \
+              'Consider using e.g. `stub_const`.'
+        RESTRICT_ON_SEND = %i[send __send__].freeze
+
+        # @!method remove_const(node)
+        def_node_matcher :remove_const, <<~PATTERN
+          (send _ {:send | :__send__} (sym :remove_const) _)
+        PATTERN
+
+        # Check for offenses
+        def on_send(node)
+          remove_const(node) do
+            add_offense(node)
+          end
+        end
+      end
+    end
+  end
+end

lib/rubocop/cop/rspec_cops.rb

@@ -107,6 +107,7 @@
 require_relative 'rspec/receive_never'
 require_relative 'rspec/redundant_around'
 require_relative 'rspec/redundant_predicate_matcher'
+require_relative 'rspec/remove_const'
 require_relative 'rspec/repeated_description'
 require_relative 'rspec/repeated_example'
 require_relative 'rspec/repeated_example_group_body'

spec/rubocop/cop/rspec/remove_const_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::RSpec::RemoveConst do
+  it 'detects the `remove_const` usage' do
+    expect_offense(<<-RUBY)
+      it 'does something' do
+        Object.send(:remove_const, :SomeConstant)
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use remove_const in specs. Consider using e.g. `stub_const`.
+      end
+    RUBY
+
+    expect_offense(<<-RUBY)
+      before do
+        SomeClass.send(:remove_const, :SomeConstant)
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use remove_const in specs. Consider using e.g. `stub_const`.
+      end
+    RUBY
+  end
+
+  it 'detects the `remove_const` usage when using `__send__`' do
+    expect_offense(<<-RUBY)
+      it 'does something' do
+        NiceClass.__send__(:remove_const, :SomeConstant)
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use remove_const in specs. Consider using e.g. `stub_const`.
+      end
+    RUBY
+  end
+end