Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maria Cheprasova - 1 #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Maria Cheprasova - 1 #59

wants to merge 1 commit into from

Conversation

moooll
Copy link

@moooll moooll commented Mar 11, 2019

Name

Valentine Zavadskiy

Homework#

0

Link to video with demo

https://www.youtube.com/watch?v=ecIWPzGEbFc

Comment

Level 1 and 2.

Checklist

  • I have read homework assignment fully
  • I have implemented homework assignment fully
  • My pull request is named "#{name} #{surname} - #{homework_number}"
  • My code is located under "#{name} #{surname}/#{homework_number}"
  • It executes correctly
  • It doesn't crash, freeze, kill everyone on unexpected input
  • Credentials are NOT hardcoded
  • Large files and credentials added to .gitignore INSIDE homework dir
  • It can be tested in under 10 minutes (download part + parse + execute)
  • Gemfile added, it runs under bundle exec without error

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

@moooll moooll changed the title task-1 almost Maria Cheprasova - 1 Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants