Maksim Filipenko - 0 #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 9, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: We found some problems with your configuration file: [/IrresponsibleMo...
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.
__Maxim-Filipenko__/0/first.rb
Outdated
| end | ||
|
|
||
| puts 'What product do you need ?' | ||
| Finder.new.searcher |
There was a problem hiding this comment.
Layout/TrailingBlankLines: Final newline missing.
__Maxim-Filipenko__/0/first.rb
Outdated
| def searcher | ||
| making_a_product_list | ||
| @list.each do |k, v| | ||
| if k.to_s.include? @answer |
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
houndci-bot
reviewed
Dec 9, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: We found some problems with your configuration file: [/IrresponsibleMo...
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.
__Maxim-Filipenko__/0/first.rb
Outdated
|
|
||
| puts 'What product do you need ?' | ||
| Finder.new.searcher | ||
|
|
There was a problem hiding this comment.
Layout/TrailingBlankLines: 1 trailing blank lines detected.
houndci-bot
reviewed
Dec 9, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: We found some problems with your configuration file: [/IrresponsibleMo...
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.
RGBD
requested changes
Dec 9, 2018
| @list.delete_if { |_k, v| v.nil? } | ||
| end | ||
|
|
||
| def searcher |
| @array2 = @a.sheet(0).column(15) | ||
| @list = {} | ||
|
|
||
| (0...@array1.length).each do |i| |
There was a problem hiding this comment.
@array1.zip(@array2).each do |v1, v2|
...(v1, v2)
| @list = {} | ||
|
|
||
| (0...@array1.length).each do |i| | ||
| @list.store(@array1[i], @array2[i]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name
Maksim Filipenko
Homework#
0
Link to video with demo
https://youtu.be/Zta2aTYtvI0
Comment
Level 1