Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: polish the bias analysis #4

Merged
merged 17 commits into from
May 28, 2024
Merged

FIX: polish the bias analysis #4

merged 17 commits into from
May 28, 2024

Conversation

nocollier
Copy link
Contributor

@nocollier nocollier commented May 13, 2024

  • Add site extraction for products like Fluxnet2015
  • Expand unit conversions to handle units like precip kg m-2 s-1 --> mm d-1
  • Settle on a method for calendar trimming
  • Create a comprehensive set of tests for CMIP6 models / all dataset types

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 81.11888% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (56d8121) to head (39cdeb6).

Files Patch % Lines
ilamb3/dataset.py 85.93% 9 Missing ⚠️
ilamb3/compare.py 73.33% 8 Missing ⚠️
ilamb3/regions.py 52.94% 8 Missing ⚠️
ilamb3/analysis/bias.py 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   81.24%   81.33%   +0.09%     
==========================================
  Files          11       12       +1     
  Lines         629      777     +148     
==========================================
+ Hits          511      632     +121     
- Misses        118      145      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nocollier nocollier merged commit 51b855f into main May 28, 2024
5 of 6 checks passed
@nocollier nocollier deleted the polish-bias branch May 28, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants