fix failed modal cross component tests in ci env #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <tygao@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #299 +/- ##
=======================================================
+ Coverage 66.91% 67.02% +0.10%
=======================================================
Files 2598 3340 +742
Lines 49149 64907 +15758
Branches 8890 10487 +1597
=======================================================
+ Hits 32889 43502 +10613
- Misses 14091 18831 +4740
- Partials 2169 2574 +405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Mar 15, 2024
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 4, 2024
* feat: add workspace list Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog Signed-off-by: tygao <tygao@amazon.com> * fix test for delete workspace modal (#299) Signed-off-by: tygao <tygao@amazon.com> * update function name and modal Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
ruanyl
pushed a commit
that referenced
this pull request
May 17, 2024
…arch-project#6525) * feat: add workspace list Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog Signed-off-by: tygao <tygao@amazon.com> * fix test for delete workspace modal (#299) Signed-off-by: tygao <tygao@amazon.com> * update function name and modal Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit 2a94f32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix failed modal cross component tests in ci env
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration