Workspace left nav bar #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor nav link updater so that the displayed links can be customized, this is majority required by workspace as with workspace, user would be able to config what features(plugins) then want to see for a workspace, this requires to filter out those links that are not configured by the user. Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #286 +/- ##
=======================================================
- Coverage 66.99% 66.91% -0.08%
=======================================================
Files 3323 3323
Lines 64476 64529 +53
Branches 10390 10398 +8
=======================================================
- Hits 43195 43181 -14
- Misses 18741 18809 +68
+ Partials 2540 2539 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
force-pushed
the
workspace-left-nav-bar
branch
from
efc9053 to
ba53768
Compare
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am
reviewed
Mar 8, 2024
| return item; | ||
| private filterNavLinks(core: CoreStart) { | ||
| const currentWorkspace$ = core.workspaces.currentWorkspace$; | ||
| let filterLinksByWorkspace: LinksUpdater; |
There was a problem hiding this comment.
will this filterLinksByWorkspace always be undefined, if switch to another workspace and whole page get refreshed?
There was a problem hiding this comment.
Yes, it's always undefined if page get refreshed. But this implementation should handle both refresh and non-refresh cases.
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 18, 2024
* revert unnecessary changes to recently viewed component refactor nav link updater so that the displayed links can be customized, this is majority required by workspace as with workspace, user would be able to config what features(plugins) then want to see for a workspace, this requires to filter out those links that are not configured by the user. Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix test snapshot Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * tweak comments Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revert changes to NavLinksService and CollapsibleNav component.
New feature added to NavLinksService: refactor nav link updater so that the displayed links can be customized, this is majority required by workspace as with workspace, user would be able to config what features(plugins) then want to see for a workspace, this requires to filter out those links that are not configured by the user.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration