From a73de770a39fb1c7f06c69bd9dc25bef4f088104 Mon Sep 17 00:00:00 2001
From: Andrea Sgattoni <andrea.sgattoni@rte-france.com>
Date: Fri, 17 Nov 2023 16:03:36 +0100
Subject: [PATCH] suggestions by @flomnes

---
 ortools/linear_solver/xpress_interface.cc      | 8 ++++----
 ortools/linear_solver/xpress_interface_test.cc | 3 +--
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/ortools/linear_solver/xpress_interface.cc b/ortools/linear_solver/xpress_interface.cc
index 453f1ab72ba..b707c15a7e8 100644
--- a/ortools/linear_solver/xpress_interface.cc
+++ b/ortools/linear_solver/xpress_interface.cc
@@ -358,8 +358,8 @@ class XpressInterface : public MPSolverInterface {
   bool IsMIP() const override { return mMip; }
 
   void SetStartingLpBasis(
-      const std::vector<MPSolver::BasisStatus>& /*variable_statuses*/,
-      const std::vector<MPSolver::BasisStatus>& /*constraint_statuses*/) override;
+      const std::vector<MPSolver::BasisStatus>& variable_statuses,
+      const std::vector<MPSolver::BasisStatus>& constraint_statuses) override;
 
   void ExtractNewVariables() override;
   void ExtractNewConstraints() override;
@@ -1758,8 +1758,8 @@ void XpressInterface::SetStartingLpBasis(
     LOG(DFATAL) << __FUNCTION__ << " is only available for LP problems";
     return;
   }
-  initial_variables_basis_status_=XpressBasisStatusesFrom(variable_statuses);
-  initial_constraint_basis_status_=XpressBasisStatusesFrom(constraint_statuses);
+  initial_variables_basis_status_ = XpressBasisStatusesFrom(variable_statuses);
+  initial_constraint_basis_status_ = XpressBasisStatusesFrom(constraint_statuses);
 }
 
 bool XpressInterface::readParameters(std::istream& is, char sep) {
diff --git a/ortools/linear_solver/xpress_interface_test.cc b/ortools/linear_solver/xpress_interface_test.cc
index cbd1351c6ca..184fe4e3596 100644
--- a/ortools/linear_solver/xpress_interface_test.cc
+++ b/ortools/linear_solver/xpress_interface_test.cc
@@ -320,8 +320,7 @@ TEST(XpressInterface, LpStartingBasis) {
 
   // Then we slightly modify the problem...
   MPObjective* obj = solver.MutableObjective();
-  obj->SetCoefficient(solver.variables().at(1),
-                      100);
+  obj->SetCoefficient(solver.variable(1), 100);
   // Here, we provide the final basis of the previous (similar) problem
   solver.SetStartingLpBasis(varStatus, constrStatus);
   solver.Solve();