Removes web3 dependency. Using ethersjs in the html tools. Refactors. #85
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tools/PrecompiledAbis.html
Outdated
| <option selected value='lovell'>Lovell</option> | ||
| <option value='arrowhead'>Arrowhead</option> | ||
| <option value='lovell'>Lovell</option> | ||
| <option selected value='arrowhead'>Arrowhead</option> |
There was a problem hiding this comment.
I'd leave Lovell as the selected option, these chanes are planned for the release of Lovell version
| @@ -10,10 +9,4 @@ describe('Bridge', () => { | |||
| it('has all the expected signatures', () => { | |||
| assert.equal(bridge.abi.length, 83); | |||
| }); | |||
|
|
|||
| it('builds a valid contract', () => { | |||
There was a problem hiding this comment.
Would it make sense to keep like this building a contract with the different library options? In that case we could have the dependencies as dev dependencies only
Not sure if it adds value really, let me know what you think
There was a problem hiding this comment.
You mean, exposing a build function so the use can send their client to get a Bridge contract instance? I'm not sure that's a good idea. If I understood correctly.
There was a problem hiding this comment.
I mean in the tests.
Have a test where the precompiled is used with ethers and one where it is used with viem. Since it will only be used in tests it's enough to add them as dev dependencies
There was a problem hiding this comment.
Added one for Ethers.
Viem got very complicated. Out of the scope for now.
tools/PrecompiledAbis.html
Outdated
| @@ -272,8 +272,7 @@ <h5 class="modal-title" id="exampleModalLabel">Abi</h5> | |||
| selectedAbisUrl.href = selectedAbiForkInfo.url; | |||
| selectedAbisUrl.textContent = selectedAbiForkInfo.url; | |||
|
|
|||
| const testnetRskUrl = 'https://public-node.testnet.rsk.co/'; | |||
| let web3; | |||
| const testnetRskUrl = 'https://public-node.rsk.co/'; | |||
There was a problem hiding this comment.
| const testnetRskUrl = 'https://public-node.rsk.co/'; | |
| const mainnetRskUrl = 'https://public-node.rsk.co/'; |
tools/RootstockBridge.html
Outdated
| @@ -139,11 +139,10 @@ <h5 class='text-center'>Simple html page to interact with the Rootstock (RSK) Bl | |||
| ]; | |||
|
|
|||
| const bridgeAddress = '0x0000000000000000000000000000000001000006'; | |||
| const testnetRskUrl = 'https://public-node.testnet.rsk.co/'; | |||
| const testnetRskUrl = 'https://public-node.rsk.co/'; | |||
There was a problem hiding this comment.
| const testnetRskUrl = 'https://public-node.rsk.co/'; | |
| const mainnetRskUrl = 'https://public-node.rsk.co/'; |
No description provided.