Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inference of annotations related to structs #15

Merged
merged 21 commits into from
Sep 3, 2024
Merged

Fix inference of annotations related to structs #15

merged 21 commits into from
Sep 3, 2024

Conversation

woosh
Copy link
Contributor

@woosh woosh commented Aug 30, 2024 •
edited
Loading

Fixes #6

This PR introduces code to support structs as function arguments and return values. It supports typedef and nested structs.

gustavung and others added 20 commits June 3, 2024 10:59
@gustavung
Handle emission of structs with basic type fields
9a57876
@gustavung
Add test for github issue 6
96ec307
Working results with lvalue
411d4ac
cleanup
9f3feed
Backup commit with find_offsets
29ab7eb
Cleanup
bd07659
More fixes of annotations for structs.
7430b7a
Investigating failure with typedef.
8bf699a
Fix nested typedef
7bcdc30
Added missing file
2386bb8
Added test cases for structs
434314a
Separation of test cases for structs
59eafcd
Add LICENSE file and headers in source files
6b8bfea
@clid
Added limitations to readme.
3aa67ba
Fix broken test oracles after adding license statement in source files
b0896cb
@gustavung
Remove generated behaviors (#8)
3e4be9b 
* Remove isp_generated behaviors
* Fix oracles for removed behaviors
@palmskog
add basic opam-based CI (#14)
9c9afbb
Removed unused files.
7f21ae1
Fix oracles after rebase
3a2885b
@woosh
Merge branch 'master' into 6-crash-when-returning-structs-from-functions
e7f2948
@woosh woosh requested a review from gustavung August 30, 2024 10:41
gustavung
gustavung reviewed Sep 2, 2024
View reviewed changes
src/isp_emitters.ml Outdated Show resolved Hide resolved
src/isp_emitters.ml Show resolved Hide resolved
src/isp_emitters.ml Outdated Show resolved Hide resolved
src/isp_emitters.ml Show resolved Hide resolved
gustavung
gustavung approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@gustavung gustavung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the latest changes.

@woosh woosh merged commit d0d8ac1 into master Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavung gustavung gustavung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when returning structs from functions
4 participants
@woosh @gustavung @clid @palmskog