Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "return" with "continue" in scroll_with_cursor #80

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

copygirl
Copy link
Contributor

@copygirl copygirl commented Dec 5, 2024

I was looking at the repo for inspiration and seemed to have found an apparent logical error: Throughout the scroll_with_cursor function, continue is used to ensure other text inputs in the query are handled even if one is skipped. This appears to not be true for one part of the code, where it returns instead.

I figured I would PR the presumed fix instead of just opening an issue, however I did NOT test this change, as I'm not a user of the code at this time. Hope this still helps.

@rparrett
Copy link
Owner

rparrett commented Dec 5, 2024

Thanks!

At a glance, I agree with your assessment, but I will do some testing before merging.

@rparrett
Copy link
Owner

rparrett commented Dec 5, 2024

Okay, this is sort of subtle -- you have to do some pretty weird stuff to trigger this, because in the most common applications, only one text input would be getting changed at any given time.

But this PR is clearly correct and fixes the issue. Thanks again!

@rparrett rparrett merged commit b1e5270 into rparrett:main Dec 5, 2024
1 check passed
@copygirl copygirl deleted the patch-1 branch December 5, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants