122 function compareto fails when comparing -0 and 0 (#124)

* fix -0 and 0 compare

Author: royNiladri

dist/esm/big-decimal.js

@@ -166,9 +166,11 @@ function testZero(number) {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.compareTo = void 0;
 var add_1 = __webpack_require__(217);
+var stripTrailingZero_1 = __webpack_require__(859);
 function compareTo(number1, number2) {
-    var _a;
+    var _a, _b;
     var negative = false;
+    _a = [number1, number2].map(function (n) { return (0, stripTrailingZero_1.stripTrailingZero)(n); }), number1 = _a[0], number2 = _a[1];
     if (number1[0] == '-' && number2[0] != "-") {
         return -1;
     }
@@ -180,7 +182,7 @@ function compareTo(number1, number2) {
         number2 = number2.substr(1);
         negative = true;
     }
-    _a = (0, add_1.pad)(number1, number2), number1 = _a[0], number2 = _a[1];
+    _b = (0, add_1.pad)(number1, number2), number1 = _b[0], number2 = _b[1];
     if (number1.localeCompare(number2) == 0) {
         return 0;
     }
@@ -208,6 +210,8 @@ function compareTo(number1, number2) {
     return 0;
 }
 exports.compareTo = compareTo;
+function checkZero(number) {
+}
 
 
 /***/ }),
@@ -631,7 +635,7 @@ function stripTrailingZero(number) {
     if (number[0] == '.') {
         number = '0' + number;
     }
-    if (isNegative) {
+    if (isNegative && number != '0') {
         number = '-' + number;
     }
     return number;

dist/esm/big-decimal.js.map

@@ -157,9 +157,11 @@ function testZero(number) {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.compareTo = void 0;
 var add_1 = __webpack_require__(217);
+var stripTrailingZero_1 = __webpack_require__(859);
 function compareTo(number1, number2) {
-    var _a;
+    var _a, _b;
     var negative = false;
+    _a = [number1, number2].map(function (n) { return (0, stripTrailingZero_1.stripTrailingZero)(n); }), number1 = _a[0], number2 = _a[1];
     if (number1[0] == '-' && number2[0] != "-") {
         return -1;
     }
@@ -171,7 +173,7 @@ function compareTo(number1, number2) {
         number2 = number2.substr(1);
         negative = true;
     }
-    _a = (0, add_1.pad)(number1, number2), number1 = _a[0], number2 = _a[1];
+    _b = (0, add_1.pad)(number1, number2), number1 = _b[0], number2 = _b[1];
     if (number1.localeCompare(number2) == 0) {
         return 0;
     }
@@ -199,6 +201,8 @@ function compareTo(number1, number2) {
     return 0;
 }
 exports.compareTo = compareTo;
+function checkZero(number) {
+}
 
 
 /***/ }),
@@ -622,7 +626,7 @@ function stripTrailingZero(number) {
     if (number[0] == '.') {
         number = '0' + number;
     }
-    if (isNegative) {
+    if (isNegative && number != '0') {
         number = '-' + number;
     }
     return number;

dist/node/js-big-decimal.js

@@ -1,6 +1,6 @@
 {
   "name": "js-big-decimal",
-  "version": "2.0.6",
+  "version": "2.0.7",
   "description": "Work with large numbers on the client side. Round them off to any required precision.",
   "main": "dist/node/js-big-decimal",
   "types": "dist/node/big-decimal",

dist/node/js-big-decimal.min.js

@@ -63,4 +63,7 @@ describe("compareTo", function () {
   it("should: 0.67, .6700 = 0", function () {
     expect(compareTo("0.67", ".6700")).toBe(0);
   });
+  it("should: -0, 0 = 0", function () {
+    expect(compareTo("-0", "0")).toBe(0);
+  });
 });

dist/web/js-big-decimal.js

@@ -1,7 +1,9 @@
 import { pad } from './add';
+import {stripTrailingZero} from './stripTrailingZero';
 
 export function compareTo(number1 : string, number2 : string) {
 	let negative = false;
+	[number1, number2] = [number1, number2].map(n => stripTrailingZero(n));
 	if(number1[0] == '-' && number2[0] != "-"){
 		return -1;
 	}else if(number1[0] != '-' && number2[0] == '-'){
@@ -33,4 +35,8 @@ export function compareTo(number1 : string, number2 : string) {
 		}
 	}
 	return 0;
+}
+
+function checkZero(number){
+
 }

dist/web/js-big-decimal.min.js

@@ -59,6 +59,21 @@ describe("stripTrailingZero", function () {
     expect(stripTrailingZero("-5.50000000000000000")).toBe("-5.5");
   });
 
+  // handle zeros
+  it("should: 0.00000 become 0", function () {
+    expect(stripTrailingZero("0.00000")).toBe("0");
+  });
+  it("should: -0.00000 become 0", function () {
+    expect(stripTrailingZero("-0.00000")).toBe("0");
+  });
+  it("should: 000 become 0", function () {
+    expect(stripTrailingZero("000")).toBe("0");
+  });
+  it("should: -000 become 0", function () {
+    expect(stripTrailingZero("-000")).toBe("0");
+  });
+
+
   // Usage in conjugation with rounding
   it("should: result of remove trailing zeroes then rounding 1.550 to 1 digit precision becomes 1.6", function () {
     expect((new bigDecimal("1.550")).stripTrailingZero().round(1).getValue()).toBe("1.6");

package-lock.json

@@ -21,7 +21,7 @@ export function stripTrailingZero(number) {
 	if (number[0] == '.') {
 		number = '0' + number;
 	}
-	if (isNegative) {
+	if (isNegative && number != '0') {
 		number = '-' + number;
 	}
 	return number;