-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 📝 add code along on renaming, editing, and moving files to working-with-files
#66
base: main
Are you sure you want to change the base?
docs: 📝 add code along on renaming, editing, and moving files to working-with-files
#66
Conversation
Not needed when sessions are this short
Along with what the repo structure looks like currently and what it will look like at the end of the session.
working-with-files
working-with-files
When we edit the content of the file in the code along
working-with-files
working-with-files
I'll leave this PR stacked, but won't stack this kind of content going forward 🚀 |
Following the feedback from the other PR, I have changed "you" to "we" in the code along. This is now ready for review 👩🎤 |
@signekb can you resolve the conflicts so I know what to review? |
@lwjohnst86 Done ✅ |
Reviewing this PR right now! 📖 ✍️ 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some suggestions 😁
sessions/working-with-files.qmd
Outdated
Once we have renamed the file, let's click the green "Commit changes" button | ||
and commit the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we have renamed the file, let's click the green "Commit changes" button | |
and commit the changes. | |
Once we have renamed the file, click the "Commit changes" button on the right side of the page. When the commit message box pops up, write in the message something like: "renamed file to something more specific". Then click the "Commit changes" button on the bottom of the message box. |
Workshop material needs to be really precise to the tasks we're doing. Since this is on Git and GitHub, we need to be detailed about all the steps.
Since we'll repeat this many times, might be worth it to consider using {{< var >}}
shortcodes to insert repeated text.
We also should be careful about saying colours. On my computer, I have it as blue (colour blind friendly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that’s some good points. I’ll create a short code with the commit steps.
About colours: could we write that it’s green by default or should we just omit the mention of a colour altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make an issue to discuss this. We don't need to commit to it immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the github-commit
variable I just added I don’t mention the colour of the buttons 🟢
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
… messages could be
…t message earlier
Description
This PR adds a code along on renaming editing and moving the
soup.md
file toworking-with-files
Related to #63
This PR needs an in-depth review.
Checklist
just run-all