Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use classic PAT generation #4117

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Jan 17, 2024

The bloom release instructions were built for the original way to create personal access tokens. Now that Github has two methods to create a PAT, we should instruct users to use the classic UI.

I tried using the new beta UI, but the token did not work, and the instructions did not line up well. A future PR could add the necessary instructions on how to use the new beta token generation., perhaps once it's out of beta.

Here is what the dropdown looks like:
image

Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jan 17, 2024
@clalancette clalancette merged commit cc6c232 into ros2:rolling Jan 17, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Jan 17, 2024
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
(cherry picked from commit cc6c232)
mergify bot pushed a commit that referenced this pull request Jan 17, 2024
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
(cherry picked from commit cc6c232)
clalancette pushed a commit that referenced this pull request Jan 17, 2024
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
(cherry picked from commit cc6c232)

Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
clalancette pushed a commit that referenced this pull request Jan 17, 2024
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
(cherry picked from commit cc6c232)

Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
@Ryanf55 Ryanf55 deleted the use-classic-ui-for-pat branch January 17, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants