-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain sphinxcontrib-applehelp. #4107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be958ab
to
ebe62d9
Compare
The new version doesn't work with Sphinx 4.3.2 anymore. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ebe62d9
to
c2a7368
Compare
I'm going to go ahead and merge this without review so we can get CI working again. |
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
The new versions doesn't work with Sphinx 4.3.2 anymore, so make sure to pin them back. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 83b610c)
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
The new versions doesn't work with Sphinx 4.3.2 anymore, so make sure to pin them back. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 83b610c)
Here is a successful run on the buildfarm as well: https://build.ros.org/job/doc_ros2doc/1182/console |
clalancette
added a commit
that referenced
this pull request
Jan 16, 2024
clalancette
added a commit
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version doesn't work with Sphinx 4.3.2 anymore.