Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain sphinxcontrib-applehelp. #4107

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

clalancette
Copy link
Contributor

The new version doesn't work with Sphinx 4.3.2 anymore.

@clalancette clalancette requested a review from audrow as a code owner January 16, 2024 13:26
@clalancette clalancette force-pushed the clalancette/constrain-applehelp branch 4 times, most recently from be958ab to ebe62d9 Compare January 16, 2024 13:35
The new version doesn't work with Sphinx 4.3.2 anymore.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette force-pushed the clalancette/constrain-applehelp branch from ebe62d9 to c2a7368 Compare January 16, 2024 13:37
@clalancette
Copy link
Contributor Author

I'm going to go ahead and merge this without review so we can get CI working again.

@clalancette clalancette merged commit 83b610c into rolling Jan 16, 2024
3 checks passed
@clalancette clalancette deleted the clalancette/constrain-applehelp branch January 16, 2024 13:42
@clalancette
Copy link
Contributor Author

@Mergifyio backport humble iron

Copy link
Contributor

mergify bot commented Jan 16, 2024

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 16, 2024
The new versions doesn't work with Sphinx 4.3.2 anymore,
so make sure to pin them back.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 83b610c)
mergify bot pushed a commit that referenced this pull request Jan 16, 2024
The new versions doesn't work with Sphinx 4.3.2 anymore,
so make sure to pin them back.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 83b610c)
@clalancette
Copy link
Contributor Author

Here is a successful run on the buildfarm as well: https://build.ros.org/job/doc_ros2doc/1182/console

clalancette added a commit that referenced this pull request Jan 16, 2024
The new versions doesn't work with Sphinx 4.3.2 anymore,
so make sure to pin them back.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 83b610c)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette added a commit that referenced this pull request Jan 16, 2024
The new versions doesn't work with Sphinx 4.3.2 anymore,
so make sure to pin them back.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 83b610c)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant