Remove duplicate argument to ros2 pkg create in tutorial page (#4103)
#4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanperez-keera
force-pushed
the
rolling
branch
2 times, most recently
from
c7f671a to
16a6487
Compare
ivanperez-keera
changed the title
ros2 pkg create in tutorial page (#4103).ros2 pkg create in tutorial page (#4103)
clalancette
approved these changes
Jan 16, 2024
clalancette
added
the
backport-all
The tutorial page to create the first ROS2 package instructs users to pass the `--license` argument twice when calling `ros2 pkg create`. Using `--license` twice has the effect that the first license in the argument list is ignored. There's no point in adding this twice, it just confuses users and makes the line longer. This commit removes the second `--license Apache-2.0` in the line for both the CMake and Python variants of the command.
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
The tutorial page to create the first ROS2 package instructs users to pass the `--license` argument twice when calling `ros2 pkg create`. Using `--license` twice has the effect that the first license in the argument list is ignored. There's no point in adding this twice, it just confuses users and makes the line longer. This commit removes the second `--license Apache-2.0` in the line for both the CMake and Python variants of the command. (cherry picked from commit eca844a)
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
The tutorial page to create the first ROS2 package instructs users to pass the `--license` argument twice when calling `ros2 pkg create`. Using `--license` twice has the effect that the first license in the argument list is ignored. There's no point in adding this twice, it just confuses users and makes the line longer. This commit removes the second `--license Apache-2.0` in the line for both the CMake and Python variants of the command. (cherry picked from commit eca844a)
This was referenced Jan 16, 2024
clalancette
pushed a commit
that referenced
this pull request
Jan 16, 2024
#4112) The tutorial page to create the first ROS2 package instructs users to pass the `--license` argument twice when calling `ros2 pkg create`. Using `--license` twice has the effect that the first license in the argument list is ignored. There's no point in adding this twice, it just confuses users and makes the line longer. This commit removes the second `--license Apache-2.0` in the line for both the CMake and Python variants of the command. (cherry picked from commit eca844a) Co-authored-by: Ivan Perez, PhD <ivan.perezdominguez@nasa.gov>
clalancette
pushed a commit
that referenced
this pull request
Jan 16, 2024
#4113) The tutorial page to create the first ROS2 package instructs users to pass the `--license` argument twice when calling `ros2 pkg create`. Using `--license` twice has the effect that the first license in the argument list is ignored. There's no point in adding this twice, it just confuses users and makes the line longer. This commit removes the second `--license Apache-2.0` in the line for both the CMake and Python variants of the command. (cherry picked from commit eca844a) Co-authored-by: Ivan Perez, PhD <ivan.perezdominguez@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tutorial page to create the first ROS2 package instructs users to pass the
--licenseargument twice when callingros2 pkg create.Using
--licensetwice has the effect that the first license in the argument list is ignored. There's no point in adding this twice, it just confuses users and makes the line longer.This commit removes the second
--license Apache-2.0in the line for both the CMake and Python variants of the command.