New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(timer): Delete node, after executor thread terminated #2737

Merged

mjcarroll merged 1 commit into ros2:rolling from cellumation:flaky_timer_test

Feb 10, 2025

Contributor

jmachowinski commented Feb 10, 2025

This fixes a potential race leading to a segfault. The segfault would happen, if the tear down of the test would occur before the timer thread stopped the spinning of the executor.

Also simplifies the test code, as the cancel of the executor is now in the TearDown().


          fix(timer): Delete node, after executor thread terminated

74cc412

This fixes a potential race leading to a segfault. The segfault would
happen, if the tear down of the test would occur before the timer thread
stopped the spinning of the executor.

Also simplifies the test code, as the cancel of the executor is now in
the TearDown().

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>

ahcorde approved these changes

View reviewed changes

Contributor

ahcorde commented Feb 10, 2025

Pulls: #2737
Gist: https://gist.githubusercontent.com/ahcorde/0f190f722457e6b4e4bbedb7efe1bc14/raw/f2ee901154ed46fddbb66b9284406cf6673792da/ros2.repos
BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp
TEST args: --packages-select rclcpp --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15153

Linux
Linux-aarch64
Linux-rhel
Windows

mjcarroll approved these changes

View reviewed changes

mjcarroll merged commit f6b80ab into ros2:rolling

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet