Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the newer Rolling and Jazzy distros in our dev Dockerfile #455

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Add support for the newer Rolling and Jazzy distros in our dev Dockerfile #455

merged 1 commit into from
Feb 3, 2025

Conversation

maspe36
Copy link
Collaborator

@maspe36 maspe36 commented Feb 2, 2025

  • Change the pip command based on the ROS_DISTRO argument
  • Swap to the PyPi version of colcon-ros-cargo
  • Only install colcon-ros-cargo as it lists colcon-cargo and cargo-ament-build as dependencies (link)

jhdcs
jhdcs approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using both jazzy and rolling repos files, and this appeared to work for me.

@jhdcs jhdcs merged commit f10fc41 into ros2-rust:main Feb 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhdcs jhdcs jhdcs approved these changes

@esteve esteve Awaiting requested review from esteve

@mxgrey mxgrey Awaiting requested review from mxgrey

@luca-della-vedova luca-della-vedova Awaiting requested review from luca-della-vedova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maspe36 @jhdcs