Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Iron support (reached EOL) #443

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

jballoffet
Copy link
Contributor

Description

This PR removes Iron Irwini ROS 2 distro support for it has reached its EOL (November 2024).

Note: PR may be kept on hold until Iron is officially sunsetted (see ros2/ros2#1627).

Context

See https://docs.ros.org/en/jazzy/Releases.html.

Change involved

This PR applies the following changes:

  • Removes Iron Irwini ROS 2 distro support from CI and code base.

How was this tested?

CI passes.

@jballoffet jballoffet force-pushed the jballoffet/remove-iron branch from 2e8d9d6 to 8f65124 Compare December 6, 2024 16:03
maspe36
maspe36 previously approved these changes Dec 9, 2024
Copy link
Collaborator

@maspe36 maspe36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, I don't have strong feelings about when to merge this. For now, I plan to wait until ros2/ros2#1627 is done.

@jballoffet
Copy link
Contributor Author

Thanks! LGTM, I don't have strong feelings about when to merge this. For now, I plan to wait until ros2/ros2#1627 is done.

Sounds good, thank you!

@maspe36
Copy link
Collaborator

maspe36 commented Feb 13, 2025

@jballoffet would you be able to fix the merge conflicts? Once that's done we're good to merge

Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>
@jballoffet
Copy link
Contributor Author

Thanks @maspe36! PR rebased.

@jballoffet jballoffet requested a review from maspe36 February 14, 2025 11:15
Copy link
Collaborator

@maspe36 maspe36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EDIT: Seems like the CI failure is a semi-known issue
#432

@maspe36 maspe36 merged commit ab4cb3c into ros2-rust:main Feb 15, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants