Disable clippy warnings for u128 types #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maspe36
requested changes
Jul 14, 2023
| @@ -3,6 +3,7 @@ | |||
| #![allow(non_upper_case_globals)] | |||
| #![allow(non_camel_case_types)] | |||
| #![allow(non_snake_case)] | |||
| #![allow(improper_ctypes)] | |||
There was a problem hiding this comment.
I think it might be a good idea to separate this not allow from the rest of the blocks and add a comment referencing that its coming from ROS 2's new runtime reflection feature in Iron and Rolling. I can see this list getting quite long and goofy over time
There was a problem hiding this comment.
I had to fix the formatting because rustfmt was complaining.
maspe36
approved these changes
Jul 15, 2023
|
@maspe36 thank you so much for the review 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320