Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GP20HL robot support package #604

Open
wants to merge 3 commits into
base: kinetic-devel
Choose a base branch
from
Open

Add GP20HL robot support package #604

wants to merge 3 commits into from

Conversation

EricMarcil
Copy link
Contributor

Add GP20HL robot support package

@EricMarcil
Add GP20HL robot support package
d699c6b 
Add GP20HL robot support package
gavanderhoorn
gavanderhoorn requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link_6_t.dae needs to be fixed.

motoman_gp20hl_support/meshes/gp20hl/visual/link_6_t.dae
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file appears to be 'empty' (as in: there's no mesh data defined here).

motoman_gp20hl_support/config/opw_parameters_gp20hl.yaml Show resolved Hide resolved
@gavanderhoorn
Copy link
Member

@EricMarcil: I just noticed #566.

Is this a copy of that PR?

@gavanderhoorn gavanderhoorn mentioned this pull request Jan 31, 2025
Open
@EricMarcil
Copy link
Contributor Author

No, it

@EricMarcil: I just noticed #566.

Is this a copy of that PR?

No, it is a new one that I made. I must have missed the #566 that was made by acbuynak.
I used the MotoSim model to generate the visual meshes in .dae which keeps the colors of the orignial model. So, I would prefer to keep this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricMarcil @gavanderhoorn