Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pid_controller] Update tests (backport #1538) #1545

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 14, 2025

Main changes


This is an automatic backport of pull request #1538 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Feb 14, 2025
Copy link
Contributor Author

mergify bot commented Feb 14, 2025

Cherry-pick of b24b310 has failed:

On branch mergify/bp/humble/pr-1538
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit b24b310.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   pid_controller/CMakeLists.txt
	new file:   pid_controller/test/test_pid_controller_dual_interface.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pid_controller/src/pid_controller.cpp
	both modified:   pid_controller/test/pid_controller_params.yaml
	both modified:   pid_controller/test/test_pid_controller.cpp
	both modified:   pid_controller/test/test_pid_controller.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 72.34043% with 26 lines in your changes missing coverage. Please review.

Project coverage is 66.89%. Comparing base (92c47bd) to head (0c03827).
Report is 2 commits behind head on humble.

Files with missing lines Patch % Lines
...roller/test/test_pid_controller_dual_interface.cpp 72.91% 0 Missing and 13 partials ⚠️
pid_controller/test/test_pid_controller.cpp 66.66% 0 Missing and 11 partials ⚠️
pid_controller/src/pid_controller.cpp 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1545      +/-   ##
==========================================
+ Coverage   66.84%   66.89%   +0.05%     
==========================================
  Files         114      115       +1     
  Lines       13459    13533      +74     
  Branches     8334     8367      +33     
==========================================
+ Hits         8996     9053      +57     
+ Misses       1436     1428       -8     
- Partials     3027     3052      +25     
Flag Coverage Δ
unittests 66.89% <72.34%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pid_controller/test/test_pid_controller.hpp 81.03% <100.00%> (+1.59%) ⬆️
pid_controller/src/pid_controller.cpp 71.55% <50.00%> (+3.98%) ⬆️
pid_controller/test/test_pid_controller.cpp 47.07% <66.66%> (-1.48%) ⬇️
...roller/test/test_pid_controller_dual_interface.cpp 72.91% <72.91%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit df1dbac into humble Feb 15, 2025
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1538 branch February 15, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants