chore: gcp code bugs #384
Merged
chore: gcp code bugs #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
romange
commented
Feb 24, 2025
•
romange
commented
- Invalid release up of the pool client handle.
- add a missing header for gcp metadata request.
chakaz
previously approved these changes
Feb 24, 2025
util/cloud/gcp/gcs.cc
Outdated
| @@ -144,9 +144,11 @@ io::Result<TokenTtl> ParseTokenResponse(std::string&& response) { | |||
| return result; | |||
| } | |||
|
|
|||
| static const char kMetaDataHost[] = "metadata.google.internal"; | |||
There was a problem hiding this comment.
Suggested change
| static const char kMetaDataHost[] = "metadata.google.internal"; | |
| static constexpr string_view kMetaDataHost = "metadata.google.internal"sv; |
Just a nit, doesn't really matter
romange
commented
Feb 24, 2025
util/cloud/gcp/gcs.cc
Outdated
| @@ -158,6 +160,7 @@ error_code ReadGCPConfigFromMetadata(fb2::ProactorBase* pb, string* account_id, | |||
| const char kEmailUrl[] = "/computeMetadata/v1/instance/service-accounts/default/email"; | |||
| h2::request<h2::empty_body> req{h2::verb::get, kEmailUrl, 11}; | |||
| req.set("Metadata-Flavor", "Google"); | |||
| req.set(h2::field::host, kMetaDataHost); | |||
There was a problem hiding this comment.
@chakaz these headers :) host was missing so the requests were rejected
There was a problem hiding this comment.
oh lol, I was thinking of C++ headers 🤦
1. Invalid release up of the pool client handle. 2. add a missing header for gcp metadata request. Signed-off-by: Roman Gershman <romange@gmail.com>
romange
changed the title
chakaz
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Now that I see that req.set() accepts a const char*, I had to verify that string_view literals ("..."sv) are null-terminated.
I looks like it is:
https://stackoverflow.com/questions/57250440/is-a-stdstring-view-literal-guaranteed-to-be-null-terminated
But still, it seems to have been a not-so-great advice on my behalf :|
Anyway, LG, do whatever you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.