fix: compile on arm missing bracket on cpu_features #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <kostas@dragonflydb.io>
kostasrim
commented
Jul 1, 2024
| // See <cpuid.h> for constants reference | ||
| constexpr unsigned BIT_AVX2 = (1 << 5); | ||
| constexpr unsigned BIT_AVX512F = (1 << 16); | ||
| constexpr unsigned BIT_AVX2 = (1 << 5); |
There was a problem hiding this comment.
clang-format did not run on the previous PR 😮 ?
dranikpg
approved these changes
Jul 1, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
- Coverage 77.60% 77.29% -0.32%
==========================================
Files 103 108 +5
Lines 7824 8081 +257
==========================================
+ Hits 6072 6246 +174
- Misses 1752 1835 +83 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails to build on arm see https://github.com/dragonflydb/dragonfly/actions/runs/9743732272/job/26889678052#step:5:499