chore: http clean-up (#289)

Made http client pool compilable.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>

Author: romange

util/http/CMakeLists.txt

@@ -10,19 +10,7 @@ cxx_link(http_server_lib absl::strings absl::time base http_beast_prebuilt http_
 
 add_executable(http_main http_main.cc)
 
-add_library(http_client_lib http_client.cc)
+add_library(http_client_lib http_client.cc https_client_pool.cc)
 
 cxx_link(http_client_lib fibers2 http_beast_prebuilt http_utils tls_lib)
 cxx_link(http_main fibers2 html_lib http_server_lib TRDP::mimalloc)
-
-
-#add_library(https_client_lib https_client.cc https_client_pool.cc ssl_stream.cc)
-#cxx_link(https_client_lib proactor_lib absl_variant http_beast_prebuilt)
-
-# TODO: to fix it
-# cxx_test(ssl_stream_test https_client_lib LABELS CI)
-
-# add_library(http_test_lib http_testing.cc)
-# cxx_link(http_test_lib http_v2 gaia_gtest_main TRDP::rapidjson)
-
-# cxx_test(http_test http_v2 http_client_lib http_test_lib LABELS CI)

util/http/beast_rj_utils.h

@@ -74,16 +74,26 @@ class Client {
     on_connect_cb_ = std::move(cb);
   }
 
+  void set_retry_count(uint32_t cnt) { retry_cnt_ = cnt; }
+
+  auto native_handle() const {
+    return socket_->native_handle();
+  }
+
  protected:
   std::unique_ptr<FiberSocketBase> socket_;
 
  private:
   static bool IsIoError(BoostError ec) {
-    return bool(ec);  // TODO: currently all errors are io errors
+    using err = ::boost::beast::http::error;
+    return ec && ec != err::need_buffer;
   }
 
-  static BoostError HandleError(BoostError ec) {
-    return ec;  // TODO: a hook to print warning errors, change state etc.
+  BoostError HandleError(BoostError ec) {
+    if (IsIoError(ec)) {
+      socket_->Close();
+    }
+    return ec;
   }
 
   fb2::ProactorBase* proactor_;
@@ -98,8 +108,7 @@ class Client {
 
 template <typename Req, typename Resp> auto Client::Send(const Req& req, Resp* resp) -> BoostError {
   namespace h2 = ::boost::beast::http;
-  BoostError ec;
-  ::boost::system::error_code read_ec;
+  BoostError ec, read_ec;
   AsioStreamAdapter<> adapter(*socket_);
 
   for (uint32_t i = 0; i < retry_cnt_; ++i) {