Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci/bench/node): refine configuration #739

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Apr 3, 2024

Description

Closes #706.

I have to say there are a lot of noise on node benchmark action for small project. Only threejs10x has some stable data.

@hyf0 hyf0 marked this pull request as ready for review April 3, 2024 18:14
Copy link
Member Author

hyf0 commented Apr 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 22f48cd
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/660db4b4d93185000887ecb8

@hyf0 hyf0 force-pushed the 04-04-feat_test_performance branch from 5d2efc8 to 7db54dc Compare April 3, 2024 18:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 22f48cd Previous: 5cab786 Ratio
threejs10x 336.15 ms / ops 372.51 ms 0.90
threejs10x-sourcemap 468.80 ms / ops 322.04 ms 1.46

This comment was automatically generated by workflow using github-action-benchmark.

@hyf0 hyf0 mentioned this pull request Apr 3, 2024
@hyf0 hyf0 changed the title feat: test performance chore(ci/bench-node): proper permission for benchmark node action Apr 3, 2024
@hyf0 hyf0 changed the title chore(ci/bench-node): proper permission for benchmark node action chore(ci/bench/node): proper permission for benchmark node action Apr 3, 2024
@hyf0 hyf0 changed the title chore(ci/bench/node): proper permission for benchmark node action chore(ci/bench/node): refine configuration Apr 3, 2024
@hyf0
Copy link
Member Author

hyf0 commented Apr 3, 2024

threejs10x-sourcemap become slow due we aren't enable sourcemap for sourcemap benchmark.

@hyf0 hyf0 merged commit a877fc0 into main Apr 3, 2024
17 of 18 checks passed
@hyf0 hyf0 deleted the 04-04-feat_test_performance branch April 3, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant