Small change to AsContainer

Small change to AsContainer.
Avoid double checking with "is" and then "as".
Do a Cast and then check on null.
The Check for WindowsFramework.Wpf is moved to UIItem.cs

Author: dpisanu

src/TestStack.White/UIItems/UIItem.cs

@@ -201,10 +201,10 @@ public virtual bool Visible
         /// <returns></returns>
         public virtual string ErrorProviderMessage(Window window)
         {
-            AutomationElement element =
+            var element =
                 AutomationElement.FromPoint(automationElement.Current.BoundingRectangle.ImmediateExteriorEast());
             if (element == null) return null;
-            Rect errorProviderBounds = element.Current.BoundingRectangle;
+            var errorProviderBounds = element.Current.BoundingRectangle;
             if (automationElement.Current.BoundingRectangle.Right != errorProviderBounds.Left) return null;
             mouse.Location = errorProviderBounds.Center();
             actionListener.ActionPerformed(Action.WindowMessage);
@@ -421,8 +421,16 @@ protected virtual void EnterData(string value)
             }
         }
 
-        internal virtual IUIItemContainer AsContainer()
+        /// <summary>
+        /// Make an <see cref="IUIItemContainer"/> out of the <see cref="IUIItem"/>
+        /// </summary>
+        /// <returns>Returns an <c><see cref="IUIItemContainer"/></c> if possibe</returns>
+        public virtual IUIItemContainer AsContainer()
         {
+            if (Framework != WindowsFramework.Wpf)
+            {
+                Logger.Warn("Only WPF items should be treated as container items");
+            }
             return new UIItemContainer(AutomationElement, ActionListener);
         }
 

src/TestStack.White/UIItems/WPFUIItems/WPFUIItem.cs

@@ -1,5 +1,3 @@
-using Castle.Core.Logging;
-using TestStack.White.Configuration;
 using TestStack.White.UIItems.Finders;
 
 namespace TestStack.White.UIItems.WPFUIItems
@@ -9,8 +7,6 @@ namespace TestStack.White.UIItems.WPFUIItems
     /// </summary>
     public static class WPFUIItem
     {
-        static readonly ILogger Logger = CoreAppXmlConfiguration.Instance.LoggerFactory.Create(typeof (WPFUIItem));
-
         #region Get Single UI Item
 
         /// <summary>
@@ -143,15 +139,12 @@ public static bool Exists(this IUIItem uiItem, SearchCriteria searchCriteria)
 
         private static IUIItemContainer GetUiItemContainer(IUIItem uiItem)
         {
-            if (!(uiItem is UIItem))
+            var item = uiItem as UIItem;
+            if (item == null)
             {
                 throw new WhiteException("Cannot get UI Item container, uiItem must be an instance of UIItem");
             }
-            if (uiItem.Framework != WindowsFramework.Wpf)
-            {
-                Logger.Warn("Only WPF items should be treated as container items");
-            }
-            return ((UIItem) uiItem).AsContainer();
+            return item.AsContainer();
         }
 
         #endregion