-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean translation #2848
Add Korean translation #2848
Conversation
@rivercory Thank you for the Pull Request. What to do next? If you want to talk more about this, please use our #ride channel in Slack. |
@rivercory I saw you PR at robotframework, and there is a big list of pending PR there. I decided to integrate robotframework's languages.py file in RIDE code. This means that I have integrated your PR in my PR #2851, essentially the localization structure. With this PR, I have setup Korean to be translated at Crowdin (which I hope you can be a translator, and advertise to your colleagues and friends). Now, one thing I would like to advise to you, is the way "we" expect the PR to be created. I say we, because in general, and in particular in GitHub RobotFramework projects, PR should be created from a topic branch (a dedicated branch to the changes). Please see the CONTRIBUTING document (and also the one at core RobotFramework). Thanks. |
@HelioGuilherme66 |
Yes, that is the usual process. But if you use an external tool like,
I don't control that, and the owner is temporarily away, so it may take some time. I am sure it will be merged. |
@HelioGuilherme66 |
Yes, you can close, because it came from |
I added Korean translations for the convenience of Korean users!
Please review my PR and give me feedback!