-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LD_LIBRARY_PATH instructions #144
Conversation
I don't know when this changed but setting LD_LIBRARY_PATH is not necessary, TAGLIB_DIR works fine and this is simpler.
0136484
to
8963b49
Compare
Is it not necessary anymore? |
@robinst wouldn't CI fail if it was still needed? I also don't need it locally. |
When you run This is why
|
I wonder if the need to use LD_LIBRARY_PATH had to do with the problem solved (in Namely, if you have a TagLib installation in |
Was just wondering why we even had it in the first place. Merged! |
This simplifies the instructions for developers and our CI settings.