Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change overflow-y value from scroll to auto in the NavLinks container (fix #7 PR) #11

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

grzegorzpokorski
Copy link
Contributor

This PR deliver more appropriate solution for issue presented in #6 issue and replace code from #7 PR. Scroll-y: auto provides, in more intelligent way, a scroll bar only when it is necessary instead of adding it in all cases.

@vercel
Copy link

vercel bot commented Jul 2, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @robert-orlinski on Vercel.

@robert-orlinski first needs to authorize it.

@robert-orlinski
Copy link
Owner

Thank you @grzegorzpokorski! As I remember (I am not sure how much "a rule" is it), most of new environments (browser + OS) hides scrollbar if not needed even if we use overflow-y: scroll but for older ones - it's awesome to have overflow-y: auto in place, as you added here 🥳

@robert-orlinski robert-orlinski merged commit 236073a into robert-orlinski:main Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants