Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Refactoring the data collector script #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpodivin
Copy link
Contributor

@jpodivin jpodivin commented Feb 19, 2025

Description

Please don't merge this for now, until it's absolutely certain what will be necessary on the config side.

Included:

  • script now reads config files only when called as main.
  • decorator turned into simple loop
  • configuration for collector will now depend on collection being enabled
  • there are no more default user agents
  • tests of data collector no longer need global override for imports
  • maximum size of user data is now defined in config

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant