Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Config File Loading #357

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Feb 4, 2025

Description

This PR adds the ability to load an additional configuration file alongside the RCS_CONFIG_FILE. This change currently supports the RHDH config map responsible for containing OLS plugin information, but can be extended to any additional configuration files. The file can be loaded and referenced similar to RCS through the RHDH_CONFIG_FILE environment variable.

The proposed change will grab all OLS related data and attempt to add providers defined in RHDH to RCS. These providers can then be used when hitting the /query endpoint.

You can find a demo overview of this change here: https://drive.google.com/file/d/1XDWqnSA7-Mz5hppiDAgDcIoYfNou3Tfn/view?usp=sharing

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it look ok, but I need some time to check it. Sorry!

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok!

@tisnik tisnik merged commit 37c3295 into road-core:main Feb 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Allow Additional Configuration Files
2 participants