Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept input objects when required arguments aren't provided but have defaults #4811

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Accept input objects when required arguments aren't provided but have defaults #4811

merged 1 commit into from
Jan 26, 2024

Conversation

rmosolgo
Copy link
Owner

Fixes #4728

@rmosolgo rmosolgo added this to the 2.2.7 milestone Jan 26, 2024
@rmosolgo rmosolgo merged commit 34e8a8d into master Jan 26, 2024
12 checks passed
@rmosolgo rmosolgo deleted the fix-non-null-args-with-default branch January 26, 2024 20:57
@rmosolgo
Copy link
Owner Author

rmosolgo commented Jan 26, 2024 •
edited
Loading

Honestly, this had me wondering, "What is the point of a non-null argument with a default value?" But I re-read the spec and realized that it prevents you from passing null as a given value. I tested that this works according to the spec at 58b5a3c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.7
Development

Successfully merging this pull request may close these issues.

Required input with default value cannot be omitted
1 participant
@rmosolgo