Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sentry tracing #3655

Closed
Frederik-Baetens opened this issue Oct 16, 2021 · 9 comments · Fixed by #4775
Closed

Add support for sentry tracing #3655

Frederik-Baetens opened this issue Oct 16, 2021 · 9 comments · Fixed by #4775

Comments

@Frederik-Baetens
Copy link

Is your feature request related to a problem? Please describe.

I'd like to be able to use graphql-ruby together with sentry's tracing.

Describe the solution you'd like

It would be nice if i could see separate traces for all graphql queries in sentry's tracing.

Describe alternatives you've considered

I've tried appsignal since they also have a plan for non-profits, but there there's also no per query tracing yet.

Additional context

https://docs.sentry.io/product/sentry-basics/tracing/distributed-tracing/

@rmosolgo
Copy link
Owner

Hi! Thanks for the suggestion. I think it'd be great to include Sentry support, hopefully the existing tracers can serve as inspiration.

@penso
Copy link

penso commented Feb 15, 2022

@Frederik-Baetens Would love to have sentry support for this, I'm using skylight for now for this which does support graphql tracing out of the box.

@Frederik-Baetens
Copy link
Author

@penso we switched to appsignal for our tracing bc they offered a non-profit plan and that works great after one of our team members made a PR here to separate the spans by graphql query.

I also used skylight, and actually preferred that, but they didn't offer a plan for non-profits.

@penso
Copy link

penso commented Feb 15, 2022

@Frederik-Baetens looks like that changed: https://www.skylight.io/oss

@Frederik-Baetens
Copy link
Author

@penso i'm aware of that, but we're a non profit with a closed source stack unfortunately, so we're not eligible for that.

@abhinaykumar
Copy link

Hi @rmosolgo, Is the support sentry is something that is in the roadmap?

@rmosolgo
Copy link
Owner

Personally, I don't have any plans to add it, no. I'd welcome a PR for it though!

@rmosolgo
Copy link
Owner

I'm going to close this since I don't have plans to work on it. But I'd welcome an addition if anyone is interested!

@patch0
Copy link
Contributor

patch0 commented Jan 10, 2024

I've opened a PR to address this in #4775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants